Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: avoid new small objects in probe stage of hash join v2 #55855

Merged
merged 5 commits into from
Sep 5, 2024
Merged

executor: avoid new small objects in probe stage of hash join v2 #55855

merged 5 commits into from
Sep 5, 2024

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Sep 4, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #53127

Problem Summary:

What changed and how does it work?

In previous implementation, probe will new a lots of small objects, this pr avoid this by reuse them.

Test Dataset: tpch-50
Test Query: select /*+ hash_join(orders) */ count(*) from orders join lineitem on l_orderkey = o_orderkey
Before this pr
img_v3_02ed_ae04358d-d4fd-431e-8eb2-d6df2c9da55g
After this pr
img_v3_02ed_78d49d72-0756-4c84-b2a9-56a97e9f895g

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2024
@tiprow tiprow
Copy link

tiprow bot commented Sep 4, 2024

Hi @windtalker. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.3407%. Comparing base (41c9926) to head (6dcd34f).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #55855         +/-   ##
=================================================
- Coverage   72.8428%   56.3407%   -16.5022%     
=================================================
  Files          1598       1724        +126     
  Lines        444498     622688     +178190     
=================================================
+ Hits         323785     350827      +27042     
- Misses       100768     248320     +147552     
- Partials      19945      23541       +3596
Flag Coverage Δ
integration 37.5645% <65.8536%> (?)
unit 72.3346% <97.5609%> (+0.3820%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.8912% <ø> (+7.1179%) ⬆️

@windtalker windtalker force-pushed the avoid_new_obj_in_probe branch from 6fe48b5 to ba357f4 Compare September 4, 2024 12:48
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2024
@windtalker windtalker force-pushed the avoid_new_obj_in_probe branch from ba357f4 to 6efb5be Compare September 5, 2024 02:29
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2024
@windtalker windtalker force-pushed the avoid_new_obj_in_probe branch from 7a8972f to 27c8c91 Compare September 5, 2024 02:39
@windtalker
save work
d4c5f73 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
save work
c013b61 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix bug
4915653 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix bug
a01735c 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix ut
6dcd34f 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker windtalker force-pushed the avoid_new_obj_in_probe branch from 77f46c7 to 6dcd34f Compare September 5, 2024 05:19
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-05 02:18:03.023341206 +0000 UTC m=+497207.541394132: ☑️ agreed by wshwsh12.
  • 2024-09-05 08:30:25.263088691 +0000 UTC m=+519549.781141616: ☑️ agreed by XuHuaiyu.

@windtalker
Copy link
Contributor Author

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Sep 5, 2024

@windtalker: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 9c7f4eb into pingcap:master Sep 5, 2024
23 checks passed
@windtalker windtalker deleted the avoid_new_obj_in_probe branch September 5, 2024 09:50
breezewish added a commit to breezewish/tidb that referenced this pull request Sep 8, 2024
@breezewish
Merge remote-tracking branch 'origin/master' into wenxuan/truncate-vecs
87c4984 
* origin/master: (33 commits)
  build(deps): bump github.com/prometheus/common from 0.55.0 to 0.57.0 (pingcap#55762)
  build(deps): bump golang.org/x/sys from 0.24.0 to 0.25.0 (pingcap#55894)
  planner: fix incorrect estRows with global index and json column (pingcap#55842)
  ddl, stat: switch to new struct for add/truncate/drop partition (pingcap#55893)
  planner: hide instance plan cache eviction log if no plan is evicted (pingcap#55918)
  expression: support tidb encode key function (pingcap#51678)
  planner: fix incorrect maintenance of `handleColHelper` for recursive CTE (pingcap#55732)
  executor: some code refine of hash join v2 (pingcap#55887)
  infoschema, meta: fix wrong auto id after `rename table` (pingcap#55847)
  ddl/ingest: set `minCommitTS` when detect remote duplicate keys (pingcap#55588)
  planner: move index advisor into the kernel (pingcap#55874)
  ddl, stats: switch to new struct for create/truncate table (pingcap#55811)
  executor: avoid new small objects in probe stage of hash join v2 (pingcap#55855)
  *: Add tidbCPU/tikvCPU into system tables (pingcap#55455)
  ddl: use static contexts in `NewReorgCopContext` (pingcap#55823)
  executor: fix index out of range bug in hash join v2 (pingcap#55864)
  executor: record index usage for the clustered primary keys (pingcap#55602)
  domain: load all non-public tables into infoschema (pingcap#55142)
  test: fix unstable TestShowViewPriv (pingcap#55868)
  ttl: add `varbinary` case for `TestSplitTTLScanRangesWithBytes` (pingcap#55863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@windtalker @XuHuaiyu @wshwsh12